I think it's probably horses for courses. It depends how much repetition you need and whether your composition is complex/innovative enough that the listener can hear something new and different (or think they have) at every repeat.
At a micro rather than macro level (i.e. talking about thematic progression rather than repeating whole pieces/cuea), I'm still a fan of the baroque/classical/romantic "repeat it twice, the third time can be similar, but at that point you have to move it on". It gives a chance for the phrase to have maimum impact, but the ear should not generally get tired of it.
On the other hand, if you were to ask Phil Glass, he'd probably give you a totally different answer... [H]
At a micro rather than macro level (i.e. talking about thematic progression rather than repeating whole pieces/cuea), I'm still a fan of the baroque/classical/romantic "repeat it twice, the third time can be similar, but at that point you have to move it on". It gives a chance for the phrase to have maimum impact, but the ear should not generally get tired of it.
On the other hand, if you were to ask Phil Glass, he'd probably give you a totally different answer... [H]